[Scummvm-tracker] [ScummVM :: Bugs] #16126: 1213 Special Edition Freeware is crashing ScummVM

[ScummVM :: Bugs]

#16126: 1213  Special Edition Freeware is crashing ScummVM
----------------------------------+--------------------------
Reporter:  webangel3              |       Owner:  (none)
    Type:  defect                 |      Status:  new
Priority:  normal                 |   Component:  Engine: AGS
 Version:                         |  Resolution:
Keywords:  1213  Special Edition  |        Game:
----------------------------------+--------------------------
Comment (by criezy):

 Running current master code (commit
 1b92a87c63b36ef6f984fb7c53932955de60bb9a) with ASAN gives this crash when
 starting episode 1:
 {{{
 =================================================================
 ==20284==ERROR: AddressSanitizer: heap-use-after-free on address
 0x0001258dde60 at pc 0x0001030827a4 bp 0x00016cfb7620 sp 0x00016cfb7618
 READ of size 4 at 0x0001258dde60 thread T0
     #0 0x0001030827a0 in Common::Array<AGS3::SpriteInfo>::reserve(unsigned
 int) array.h:400
     #1 0x00010307c778 in Common::Array<AGS3::SpriteInfo>::resize(unsigned
 int) array.h:415
     #2 0x00010307b578 in AGS3::AGS::Shared::SpriteCache::EnlargeTo(int)
 sprite_cache.cpp:166
     #3 0x0001030e730c in
 AGS3::AGS::Shared::ApplySpriteData(AGS3::GameSetupStruct&,
 AGS3::AGS::Shared::LoadedGameEntities const&, AGS3::GameDataVersion)
 main_game_file.cpp:444
     #4 0x0001030ee870 in
 AGS3::AGS::Shared::UpdateGameData(AGS3::AGS::Shared::LoadedGameEntities&,
 AGS3::GameDataVersion) main_game_file.cpp:898
     #5 0x000103561250 in AGS3::load_game_file() game_file.cpp:203
     #6 0x00010333e820 in AGS3::RunAGSGame(AGS3::AGS::Shared::String
 const&, unsigned int, int) global_game.cpp:284
     #7 0x00010356ccd8 in AGS3::RunGameUntilAborted() game_run.cpp:1113
     #8 0x000103573c5c in AGS3::initialize_start_and_play_game(int, int)
 game_start.cpp:131
     #9 0x000103556e9c in
 AGS3::initialize_engine(Std::map<AGS3::AGS::Shared::String,
 Std::map<AGS3::AGS::Shared::String, AGS3::AGS::Shared::String,
 Common::Less<AGS3::AGS::Shared::String>>,
 Common::Less<AGS3::AGS::Shared::String>> const&) engine.cpp:1160
     #10 0x000102f8d7a4 in AGS::AGSEngine::run() ags.cpp:243
     #11 0x000102f41844 in runGame(Plugin const*, OSystem&, DetectedGame
 const&, void const*) main.cpp:319
     #12 0x000102f3b314 in scummvm_main main.cpp:805
     #13 0x000102f2d6f0 in main macosx-main.cpp:44
     #14 0x00018984ab94 in start+0x17b8 (dyld:arm64e+0xfffffffffff3ab94)

 0x0001258dde60 is located 218720 bytes inside of 218736-byte region
 [0x0001258a8800,0x0001258dde70)
 freed by thread T0 here:
     #0 0x000108c6fb0c in _ZdlPv+0x74
 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x4bb0c)
     #1 0x0001032af2b0 in AGS3::unload_game() game.cpp:405
     #2 0x00010333e5a4 in AGS3::RunAGSGame(AGS3::AGS::Shared::String
 const&, unsigned int, int) global_game.cpp:270
     #3 0x00010356ccd8 in AGS3::RunGameUntilAborted() game_run.cpp:1113
     #4 0x000103573c5c in AGS3::initialize_start_and_play_game(int, int)
 game_start.cpp:131
     #5 0x000103556e9c in
 AGS3::initialize_engine(Std::map<AGS3::AGS::Shared::String,
 Std::map<AGS3::AGS::Shared::String, AGS3::AGS::Shared::String,
 Common::Less<AGS3::AGS::Shared::String>>,
 Common::Less<AGS3::AGS::Shared::String>> const&) engine.cpp:1160
     #6 0x000102f8d7a4 in AGS::AGSEngine::run() ags.cpp:243
     #7 0x000102f41844 in runGame(Plugin const*, OSystem&, DetectedGame
 const&, void const*) main.cpp:319
     #8 0x000102f3b314 in scummvm_main main.cpp:805
     #9 0x000102f2d6f0 in main macosx-main.cpp:44
     #10 0x00018984ab94 in start+0x17b8 (dyld:arm64e+0xfffffffffff3ab94)

 previously allocated by thread T0 here:
     #0 0x000108c6f6e4 in _Znwm+0x74
 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x4b6e4)
     #1 0x000102fa7ad4 in AGS3::Globals::Globals() globals.cpp:238
     #2 0x000102fabc24 in AGS3::Globals::Globals() globals.cpp:110
     #3 0x000102f8b244 in AGS::AGSEngine::AGSEngine(OSystem*,
 AGS::AGSGameDescription const*) ags.cpp:85
     #4 0x000102f8b548 in AGS::AGSEngine::AGSEngine(OSystem*,
 AGS::AGSGameDescription const*) ags.cpp:79
     #5 0x000102fd5560 in AGSMetaEngine::createInstance(OSystem*, Engine**,
 AGS::AGSGameDescription const*) const metaengine.cpp:42
     #6 0x000102fd84d4 in
 AdvancedMetaEngine<AGS::AGSGameDescription>::createInstance(OSystem*,
 Engine**, void const*) const advancedDetector.h:725
     #7 0x00010381af3c in AdvancedMetaEngineBase::createInstance(OSystem*,
 Engine**, DetectedGame const&, void const*) advancedDetector.cpp:1165
     #8 0x000102f40430 in runGame(Plugin const*, OSystem&, DetectedGame
 const&, void const*) main.cpp:217
     #9 0x000102f3b314 in scummvm_main main.cpp:805
     #10 0x000102f2d6f0 in main macosx-main.cpp:44
     #11 0x00018984ab94 in start+0x17b8 (dyld:arm64e+0xfffffffffff3ab94)
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16126#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM