[Scummvm-tracker] [ScummVM :: Bugs] #15999: TETRAEDGE: Issues with Syberia 1 and 2 in ScummVM 2.9.1 and 2.10.0git

[ScummVM :: Bugs]

#15999: TETRAEDGE: Issues with Syberia 1 and 2 in ScummVM 2.9.1 and 2.10.0git
-------------------------------------------------+-------------------------
Reporter:  antoniou79                            |       Owner:  (none)
    Type:  defect                                |      Status:  new
Priority:  normal                                |   Component:  Engine:
                                                 |  Tetraedge
 Version:                                        |  Resolution:
Keywords:  Syberia 1, Syberia 2, sound, glitch,  |        Game:
  logo, stuck                                    |
-------------------------------------------------+-------------------------
Comment (by antoniou79):

 I have two findings so far:
 - If I build branch-2-9-1 locally (MINGW64/MSYS2, freshly updated), with
 configure: `./configure --disable-debug --enable-release --enable-lld`
 then the resulting `scummvm.exe` will run Syberia 1 and Syberia 2 (same
 PC, same folders) without the above issues (the logo transition to main
 menu works, and there are marker icons appearing in the game screens. Also
 no awry animation or bad sound issues that I could notice). But the zipped
 version from our FRS for 2.9.1 and the update version that installs over
 the existing 2.9.0 both have the issues mentioned in the original post.

 - For the issue of missing markers icons in 2.10.0git, it seems that when
 the engine looks up for a path like eg. "menus\Markers\Fleche_135.anim"
 (note: "Fleche_135.anim" is a folder here), under the "Resources" folder,
 it fails to find it as a cached name directory and gives up. I've changed
 the following line:
 https://github.com/scummvm/scummvm/blob/6546d1850a5a5f69b15564c1c971cbc435a9cd65/common/fs.cpp#L355
 replacing `_fileCache` with `_subDirCache` and it now works, but obviously
 this being a change in common/fs.cpp I'm not sure if it fixes a bug or
 creates more issues down the line. But, yeah, I think that indeed the
 "regression" for the icons is related to changes outside the engine
 itself, and those changes are related to recent changes on caching data
 files and directories for a game and/or searching for data files under
 "archives".
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15999#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM