[Scummvm-tracker] [ScummVM :: Bugs] #15509: SCUMM: Detection of Mac version of MI1 from the LucasArts Mac CD Game Pack is broken when using Dumper Companion

[ScummVM :: Bugs]

#15509: SCUMM: Detection of Mac version of MI1 from the LucasArts Mac CD Game Pack
is broken when using Dumper Companion
-------------------------+------------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: SCUMM
 Version:                |  Resolution:
Keywords:                |        Game:  Monkey Island 1
-------------------------+------------------------------
Comment (by sev-):

 The proper way of handling it is to use the MacResource class for
 accessing these files. That is written in a way that it should be format-
 agnostic. So far, we are supporting seven formats, and there is yet
 AppleOne, which we do not support, and maybe never support, as it was used
 in a relatively short timespan and was replaced by AppleDouble.

 For the SCUMM engine, it could be two-fold. Besides accessing the files in
 the engine itself, its custom detection code may also attempt to compute
 MD5s for the first 5000 bytes as is, but in MacBinary format, the first
 128 bytes are the header, which is mutable.

 ResEdit may report 0 bytes of resource fork because resource forks have
 their own structure. They contain a smaller header, an index of resources,
 and the so-called "Data Part," which typically is a concatenated set of
 resources, though I do not exclude padding in between. In the
 AdvancedDetector, we compute the MD5 of this data portion, not from the
 beginning of the resource fork.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15509#comment:9>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM