[Scummvm-tracker] [ScummVM :: Bugs] #15884: SCUMM: INDY4: ASan o5_stringOps() heap buffer-overflow in copy-protection screen

[ScummVM :: Bugs]

#15884: SCUMM: INDY4: ASan o5_stringOps() heap buffer-overflow in copy-protection
screen
---------------------+------------------------------
Reporter:  dwatteau  |       Owner:  eriktorbjorn
    Type:  defect    |      Status:  pending
Priority:  normal    |   Component:  Engine: SCUMM
 Version:            |  Resolution:  fixed
Keywords:            |        Game:  Indiana Jones 4
---------------------+------------------------------
Changes (by eriktorbjorn):

 * owner:  (none) => eriktorbjorn
 * resolution:   => fixed
 * status:  new => pending

Comment:

 This should be fixed now, but it's worrying that there are scripts like
 this. I noticed tgat VGA Loom writes outside a string when the game
 starts. No idea what that's about.

 Since the ScummVM resource manager always allocates two extra bytes per
 resource, I've relaxed the bounds check so that reads and writes to this
 "safe area" are still allowed. They're not good, but they were still well
 defined.

 Anything outside that is blocked. Let's hope nothing breaks!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15884#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM