[Scummvm-tracker] [ScummVM :: Bugs] #15959: GUI: Close game options deselect the game if grouped by engine in List View

[ScummVM :: Bugs]

#15959: GUI: Close game options deselect the game if grouped by engine in List View
-------------------+---------------------
Reporter:  criezy  |       Owner:  (none)
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  GUI
 Version:          |  Resolution:
Keywords:          |        Game:
-------------------+---------------------
Description changed by criezy:

Old description:

> In List view grouped by engine, if I select a game, open the game options
> and click OK, this deselects the game. This does not seem to happen if no
> grouping or grouping by a different method is used.
>
> More problematic, if I then try to start the game while no game is
> selected I get a crash.
> {{{
> Assertion failed: (idx < _size), function operator[], file array.h, line
> 280.
>
> 3   __assert_rtn + 284
> 4   Common::Array<int>::operator[](unsigned int) const + 80 (array.h:280)
> 5   GUI::GroupedListWidget::getSelected() const + 72 (groupedlist.h:59)
> 6   GUI::LauncherSimple::getSelected() + 28 (launcher.cpp:1075)
> 7   GUI::LauncherDialog::handleCommand(GUI::CommandSender*, unsigned int,
> unsigned int) + 68 (launcher.cpp:758)
> 8   GUI::LauncherSimple::handleCommand(GUI::CommandSender*, unsigned int,
> unsigned int) + 780 (launcher.cpp:1336)
> 9   GUI::CommandSender::sendCommand(unsigned int, unsigned int) + 84
> (object.h:54)
> }}}

New description:

 In List view grouped by engine, if I select a game, open the game options
 and click OK, this deselects the game. This does not seem to happen if no
 grouping or grouping by a different method is used.

 More problematic, if I then try to start the game while no game is
 selected I get a crash.
 {{{
 Assertion failed: (idx < _size), function operator[], file array.h, line
 280.

 3   __assert_rtn + 284
 4   Common::Array<int>::operator[](unsigned int) const + 80 (array.h:280)
 5   GUI::GroupedListWidget::getSelected() const + 72 (groupedlist.h:59)
 6   GUI::LauncherSimple::getSelected() + 28 (launcher.cpp:1075)
 7   GUI::LauncherDialog::handleCommand(GUI::CommandSender*, unsigned int,
 unsigned int) + 68 (launcher.cpp:758)
 8   GUI::LauncherSimple::handleCommand(GUI::CommandSender*, unsigned int,
 unsigned int) + 780 (launcher.cpp:1336)
 9   GUI::CommandSender::sendCommand(unsigned int, unsigned int) + 84
 (object.h:54)
 }}}

 This is on macOS Apple Silicon with current master (2.10.git).

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15959#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM