[Scummvm-tracker] [ScummVM :: Bugs] #15518: GUI: Game Options dialog can create inconsistent settings

[ScummVM :: Bugs]

#15518: GUI: Game Options dialog can create inconsistent settings
-------------------------+---------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  GUI
 Version:                |  Resolution:
Keywords:                |        Game:
-------------------------+---------------------
Description changed by eriktorbjorn:

Old description:

> This bug report grew out of https://bugs.scummvm.org/ticket/15457
>
> When overriding settings, the Game Options dialog is a bit inconsistent
> about what it saves and what it doesn't when overriding settings. For
> instance, `"speech_mute"` is always saved, but `"subtitles"` is only
> saved if the setting has been changed. Which could lead to the following
> scenario:
>
> Start with the global setting for voice/speech as "Subtitles", i.e. the
> [scummvm] section will have
>
> {{{
> subtitles=true
> speech_mute=true
> }}}
>
> Add agame, overriding the Audio settings, but do not touch the
> Speech/Subtitles setting. The game will now have:
>
> {{{
> speech_mute=true
> }}}
>
> Because, as stated above, the speech_mute setting is always saved, even
> if subtitles is not.
>
> Change the global setting to "Speech". The global options are now:
>
> {{{
> subtitles=false
> speech_mute=false
> }}}
>
> And the game settings are still
>
> {{{
> speech_mute=true
> }}}
>
> When you start the game, technically it will have neither speech nor
> subtitles. The game engine may compensate for that (it appears SCI does,
> at ethe very least). When editing the game settings, ScummVM will
> complain but recover:
>
> {{{
> WARNING: Wrong configuration: Both subtitles and speech are off. Assuming
> subtitles only!
> }}}
>
> So the situation isn't as bad as it could be. But it still seems wrong
> that you can change the overriden settings by changing the global
> settings. It seems to me that if you've selected to override, it should
> save the current state of all those settings as game specific.

New description:

 This bug report grew out of https://bugs.scummvm.org/ticket/15457

 When overriding settings, the Game Options dialog is a bit inconsistent
 about what it saves and what it doesn't when overriding settings. For
 instance, `"speech_mute"` is always saved, but `"subtitles"` is only saved
 if the setting has been changed. Which could lead to the following
 scenario:

 Start with the global setting for voice/speech as "Subtitles", i.e. the
 [scummvm] section will have

 {{{
 subtitles=true
 speech_mute=true
 }}}

 Add a game, overriding the Audio settings, but do not touch the
 Speech/Subtitles setting. The game will now have:

 {{{
 speech_mute=true
 }}}

 Because, as stated above, the speech_mute setting is always saved, even if
 subtitles is not.

 Change the global setting to "Speech". The global options are now:

 {{{
 subtitles=false
 speech_mute=false
 }}}

 And the game settings are still

 {{{
 speech_mute=true
 }}}

 When you start the game, technically it will have neither speech nor
 subtitles. The game engine may compensate for that (it appears SCI does,
 at the very least). When editing the game settings, ScummVM will complain
 but recover:

 {{{
 WARNING: Wrong configuration: Both subtitles and speech are off. Assuming
 subtitles only!
 }}}

 So the situation isn't as bad as it could be. But it still seems wrong
 that you can change the overridden settings by changing the global
 settings. It seems to me that if you've selected to override, it should
 save the current state of all those settings as game specific.

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/15518#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM