[Scummvm-tracker] [ScummVM :: Bugs] #16720: MYST3: Toggling the widescreen mod setting removes the subtitles setting from the game's configuration

[ScummVM :: Bugs]

#16720: MYST3: Toggling the widescreen mod setting removes the subtitles setting
from the game's configuration
-----------------------+----------------------------
Reporter:  antoniou79  |       Owner:  (none)
    Type:  defect      |      Status:  new
Priority:  normal      |   Component:  Engine: Myst3
 Version:              |  Resolution:
Keywords:              |        Game:  Myst 3: Exile
-----------------------+----------------------------
Comment (by antoniou79):

 What seems to be happening here, is that Myst 3 uses the GUI options
 GUIO_NOSPEECH, GUIO_NOSUBTITLES (among others, see:
 engines/myst3/detection.cpp) and this makes it so, in
 OptionsDialog::apply() (in gui/options.cpp) the "subtitles" and
 "speech_mute" key/value entries get explicitly removed from the game
 domain settings.

 GUIO_NOSPEECH behaves as GUIO_NOSUBTITLES and GUIO_NOSPEECHVOLUME
 according to gui_options.h

 In this particular case, it seems that Myst 3 uses these options because
 the engine / the game does not support changing the speech volume
 separately, nor just disabling speech, nor setting subtitles speed.
 However, the engine does support a setting of subtitles on/off.

 In the common gui code, the options GUIO_NOSPEECH, GUIO_NOSUBTITLES seem
 to be handled according to a more "strict" definition of the engine not
 supporting speech, and not supporting a toggle between the three states of
 "speech","subtitles" and "both" or other changing subtitle specific
 settings (ie. speed).

 One potential fix would be to introduce an additional GUIO (eg.
 GUIO_SUBTITLES_ONOFF) which in combination with GUIO_NOSPEECH would allow
 "Text and Speech" to only be set to "Subtitles" or "Both" for the game
 domain. And then handle it in the if (_enableSubtitleToggle) { } part of
 ptionsDialog::apply() or introduce an additional
 _enableSubtitleOnOffToggle flag to be handled, in order to differentiate
 between allowing the 3-state toggle (speech only, subtitles only, both)
 and the 2-state toggle (subtitles on, subtitles off).
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16720#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM