[Scummvm-tracker] [ScummVM :: Bugs] #17088: SCUMM: Rebel Assault 2, weapon auto-fires

[ScummVM :: Bugs]

#17088: SCUMM: Rebel Assault 2, weapon auto-fires
-------------------------+---------------------------
Reporter:  eriktorbjorn  |      Owner:  (none)
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  Engine: SCUMM
 Version:                |   Keywords:
    Game:                |
-------------------------+---------------------------
 Often when I've tried Rebel Assault 2 (I haven't tried Rebel Assault 1 far
 enough to see if it also happens there), my weapon is auto-firing with no
 way to make it stop.

 I thought the problem was gone, but yesterday I saw it again.

 As far as I can tell, `InsaneRebel2::processMouse()` queries the mouse
 button state, which say that no button is pressed. So far, so good. But it
 also calls `_vm->getActionState()` to test for some flags, and based on
 those it determined that ''both'' mouse buttons were pressed.

 `ScummEngine::getActionState()` looks at `_actionMap[]`. This array is
 initialized by `ScummEngine::resetScumm()`, which is called by
 `ScummEngine::init()`.

 But for Rebel Assault 1 and 2, that function terminates before
 `resetScumm()` is called:

 {{{
         if (_game.id == GID_REBEL1 || _game.id == GID_REBEL2) {
                 _setupIsComplete = true;
                 return Common::kNoError;
         }
 }}}

 So presumably (I have not verified this), `_actionMap[]` contains
 uninitialized data, which happens to be `true` for me.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/17088>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM