[Scummvm-tracker] [ScummVM :: Bugs] #7012: SHERLOCK: volume settings don't work

[ScummVM :: Bugs]

#7012: SHERLOCK: volume settings don't work
-------------------------+-------------------------------------------------
Reporter:  SF/mimdoe     |       Owner:  dreammaster
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: Sherlock
 Version:                |  Resolution:
Keywords:                |        Game:  Sherlock Holmes: Case of the Rose
                         |  Tattoo
-------------------------+-------------------------------------------------
Comment (by Miguel-Herrero):

 In [changeset:"0cfab98091caabdef772c9bbbd3291ec2976bb3b" 0cfab98]:
 {{{#!CommitTicketReference repository=""
 revision="0cfab98091caabdef772c9bbbd3291ec2976bb3b"
 SHERLOCK: Fix volume controls for MIDI music

 Map kPlainSoundType to the music volume so that the Music slider
 controls MIDI playback. Emulated MIDI synths (OPL, MT-32,
 FluidSynth) register their audio output with the mixer as
 kPlainSoundType (hardcoded in audio/chip.cpp and audio/softsynth/),
 which was previously only set by the SFX volume control.

 - Music::setMusicVolume(): Also set kPlainSoundType so the in-game
   Music slider in Rose Tattoo affects MIDI music.
 - Music::syncMusicSettings(): Re-apply kPlainSoundType with the
   music volume after Engine::defaultSyncSoundSettings() resets it
   to max. This covers the ScummVM global options dialog.
 - Sound::setVolume(): Remove kPlainSoundType so the SFX/voices
   slider no longer affects MIDI music.

 Fixes bug #7012.

 Co-authored-by: Cursor <cursoragent at cursor.com>
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/7012#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM