[Scummvm-tracker] [ScummVM :: Bugs] #16438: GOB: LIT CD - Phonograph in captain's cabin does not play music

[ScummVM :: Bugs]

#16438: GOB: LIT CD - Phonograph in captain's cabin does not play music
-------------------------+-------------------------
Reporter:  joshas        |      Owner:  (none)
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  Engine: Gob
 Version:                |   Keywords:  CD, audio
    Game:  Lost in Time  |
-------------------------+-------------------------
 Bug details:
 In act 3, after setting up phonograph and clicking "start button" ADL
 music track should start playing, as it does in floppy version, but in CD
 version all other background music stops and no audio track is played.

 Original game in DOSBox has exactly the same issue: no music, but after
 applying patch (https://archive.org/details/LITCD_ZIP) phonograph music
 starts working.
 This is very peculiar situation, as game developers probably did not
 bother remastering phonograph record music in CD audio, and kept ADL
 track. But due to some unknown circumstances, game was shipped with a bug,
 where ADL player was disabled in CD version. And ScummVM implemented it
 exactly as it was. Very likely, that not many players cared about that
 music track and probably no one bothered to install patch and see what it
 does, especially while readme states "This patch will fix problems that
 occur in conjunction with certain
 sound cards and CD ROM drives.", nothing about fixes.

 I wonder, what approach should be taken to fix this issue in ScummVM? One,
 very naive solution comes to mind: add both flags "kFeaturesCD |
 kFeaturesAdLib" to detection file. I tested this very briefly and it seems
 to work. But, I did not test whole game - this might break something else.
 And it might be possible, that some other changes were introduced by the
 patch. Patch only makes changes to game executable, not any of the
 resource files, so it cannot be used by ScummVM.

 ScummVM version: 2.9.1 (stable), also tested in latest master build from
 git.
 Game language: English
 Game version: CD
 Platform and Compiler: Linux

 In attached saved game click "Phonograph" and then click "The start
 button" hotspot. In current version of ScummVM there should be no audible
 music after that action. In patched version of original game in DOSBox,
 ADL audio track is played.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16438>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM