[Scummvm-tracker] [ScummVM :: Bugs] #16393: SWORD1: Harsh noise for some Broken Sword 1 releases on big-endian ports

[ScummVM :: Bugs]

#16393: SWORD1: Harsh noise for some Broken Sword 1 releases on big-endian ports
----------------------------------------+-----------------------------
Reporter:  TwistedZeon                  |       Owner:  (none)
    Type:  defect                       |      Status:  new
Priority:  high                         |   Component:  Engine: Sword1
 Version:                               |  Resolution:
Keywords:  audio,big-endian,endianness  |        Game:  Broken Sword 1
----------------------------------------+-----------------------------
Comment (by criezy):

 Copying information that I posted in Discord:
 * Currently we always assume that the speech data is LE.
 * With original versions (wave data) this is always the case, except for
 some mac releases. We have an heuristic to detect those and convert BE
 data to LE.
 * However in `expandSpeech` for compressed MP3, Vorbis, and FLAC audio we
 use an AudioStream to read the data. And `AudioStream::readBuffer`
 indicates it provides data in native endianness. This beaks the assumption
 it is LE.

 So we either need to convert from native endianess to LE in `expandSpeech`
 in the case where we use an AudioStream (so that we preserve the
 assumption it always provide LE data). Or if we allow `expandSpeech` to
 provide data in a different endianess we need to change `playSpeech` to
 provide the correct endianess to the raw stream.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16393#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM