[Scummvm-tracker] [ScummVM :: Bugs] #16485: SCI: GK2: Click Event Issue around church

[ScummVM :: Bugs]

#16485: SCI: GK2: Click Event Issue around church
----------------------+-------------------------------
Reporter:  mellinger  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: SCI
 Version:             |  Resolution:
Keywords:             |        Game:  Gabriel Knight 2
----------------------+-------------------------------
Comment (by sluicebox):

 I recognized the warning signs! That *is* a fun night!

 The specific bug here is that when standing in the middle of the church
 and clicking the south exit, there is a long pause before the room
 transition, but input isn't disabled. This allows clicking north during
 the pause, causing both exits to run at once, and that breaks the game.

 Frau Miller has (had!) the same bug:
 b6d73f54dd2c888a5ef575e6e333dc7dac2078fe

 My usual fix is to add a `handsOff` call so that input is disabled during
 the transition, just like all other transitions. The problem is that we
 can't just add code, we have to make room by optimizing the existing code
 to free up bytes, and there's very little code available. I need 11 bytes
 for `handsOff`. Most GK2 versions have extra debug instructions, so that's
 a lot of wasted bytes we can use, but that doesn't help the versions that
 don't. Any fix needs to apply to everyone, otherwise things get even more
 confusing. So I'll have to think on this one.

 I found my notes from 2019, and I called out this specific church pause as
 annoying. The game fades music and waits on it, which is (was!) another
 source of lockups: ad1ebccb3a67473a4e7293cf0ec22b3cf7a508f8
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16485#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM