[Scummvm-tracker] [ScummVM :: Bugs] #17026: [PEGASUS] Pegasus Prime broken in 2026.3.0 release
ScummVM :: Bugs
trac at scummvm.org
Tue Jul 28 05:40:42 UTC 2026
#17026: [PEGASUS] Pegasus Prime broken in 2026.3.0 release
----------------------+-----------------------------------------------
Reporter: RogerW123 | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: Engine: Pegasus
Version: | Resolution:
Keywords: | Game: Journeyman Project Pegasus Prime
----------------------+-----------------------------------------------
Comment (by eriktorbjorn):
This appears to be the commit that broken it:
{{{
8f5741a37ae1a202d0600c4dc44f000ade832fcc is the first bad commit
commit 8f5741a37ae1a202d0600c4dc44f000ade832fcc
Author: Miro Kropacek <miro.kropacek at gmail.com>
Date: Thu Apr 16 15:28:14 2026 +1000
AD: Skip detection for engines with no matching filenames
When adding a game, every engine's detection table is traversed twice
(once for MD5 pre-computation, once for matching) even if the game
folder contains none of the files that engine cares about.
Build a set of all unique filenames referenced by each engine's
detection entries during preprocessDescriptions() (called once and
cached). Before entering the expensive detection loops, check if any
file in the game folder exists in this set. If not, skip the engine
entirely.
On the Atari backend with ~60 statically linked engines, this reduces
the "Add game" time by about 30-40%.
engines/advancedDetector.cpp | 35 +++++++++++++++++++++++++++++++++++
engines/advancedDetector.h | 1 +
2 files changed, 36 insertions(+)
}}}
https://github.com/scummvm/scummvm/commit/8f5741a37ae1a202d0600c4dc44f000ade832fcc
My guess (though I haven't verified it yet) is that this change only
considers the raw filename, without considering that the Macintosh file
reader tests a few additional ones when opening a file.
--
Ticket URL: <https://bugs.scummvm.org/ticket/17026#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM
More information about the Scummvm-tracker
mailing list