[Scummvm-tracker] [ScummVM :: Bugs] #16761: NANCY: Regression in Secrets Can Kill: Eloise drawer

[ScummVM :: Bugs]

#16761: NANCY: Regression in Secrets Can Kill: Eloise drawer
--------------------------+-------------------------------------------
Reporter:  tunnelsociety  |       Owner:  (none)
    Type:  defect         |      Status:  new
Priority:  normal         |   Component:  Engine: Nancy
 Version:                 |  Resolution:
Keywords:                 |        Game:  Nancy Drew: Secrets Can Kill
--------------------------+-------------------------------------------
Comment (by tunnelsociety):

 Hmm, I was able to make the phone card appear with the following, and
 tested quickly that some inventory-dependent conversation did not differ
 in nancy9...:

 {{{#!diff
 --- a/engines/nancy/action/actionmanager.cpp
 +++ b/engines/nancy/action/actionmanager.cpp
 @@ -338,12 +338,7 @@ void
 ActionManager::processDependency(DependencyRecord &dep, ActionRecord
 &recor
                         dep.satisfied = true;
                         break;
                 case DependencyType::kInventory:
 -                       if (dep.condition == g_nancy->_false) {
 -                               // Item not in possession or held
 -                               dep.satisfied =
 !NancySceneState.hasItem(dep.label);
 -                       } else {
 -                               dep.satisfied =
 NancySceneState.hasItem(dep.label);
 -                       }
 +                       dep.satisfied = NancySceneState.hasItem(dep.label)
 == dep.condition;

                         break;
                 case DependencyType::kEvent:
 }}}

 I'll try a few things to make sure this doesn't add new problems.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16761#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM