[Scummvm-tracker] [ScummVM :: Bugs] #16720: MYST3: Toggling the widescreen mod setting removes the subtitles setting from the game's configuration

[ScummVM :: Bugs]

#16720: MYST3: Toggling the widescreen mod setting removes the subtitles setting
from the game's configuration
-----------------------+----------------------------
Reporter:  antoniou79  |       Owner:  antoniou79
    Type:  defect      |      Status:  closed
Priority:  normal      |   Component:  Engine: Myst3
 Version:              |  Resolution:  fixed
Keywords:              |        Game:  Myst 3: Exile
-----------------------+----------------------------
Changes (by antoniou79):

 * owner:  (none) => antoniou79
 * resolution:   => fixed
 * status:  new => closed

Comment:

 In [changeset:"34459a53a3b28172a1e3239d89ab43a40af91e68" 34459a53]:
 {{{#!CommitTicketReference repository=""
 revision="34459a53a3b28172a1e3239d89ab43a40af91e68"
 MYST3: Remove GUIO_NOSUBTITLES, GUIO_NOSPEECH from detection entries

 Fixes #16720

 Myst 3 has subtitles that can be enabled or disabled from its in-game
 options screen.
 The previous inclusion of GUIO_NOSUBTITLES probably meant that the user
 cannot change the subtitle settings from the ScummVM GUI (launcher or
 GMM).
 However, due to code in OptionsDialog::apply() (in gui/options.cpp) the
 "subtitles" and "speech_mute" key/value entries get explicitly removed
 from the game domain settings when changes are made and applied to game
 domain options (like toggling the widescreen mod on/off) which might
 result in an inconsistency with the user's setting of enabling subtitles
 via the game's interface as described in bug #16720.

 This fix removes GUIO_NOSUBTITLES and GUIO_NOSPEECH, thus avoiding the
 reported issue with the removal of the "subtitles" key.

 GUIO_NOSPEECH is replaced by GUIO_NOSPEECHVOLUME.

 The fix results in the subtitle settings being available for change via
 the ScummVM launcher menu (Edit Game -> Audio). If the user sets
 "subtitles" only in the Text and Speech for the game's domain or if this
 setting value is inherited from global settings, it will be changed to
 "both" (by essentially forcefully changing the "speech_mute" config key
 value to false). Any setting for subtitles speed is ignored by the game.

 Note: If we only remove GUIO_NOSUBTITLES, keeping GUIO_NOSPEECH, then the
 result is that, when overriding audio settings in the game's domain
 options, the user will see the "Text and speech" radio buttons disabled,
 but the subtitles speed setting enabled, which could be confusing. This is
 because GUIO_NOSPEECH also implies GUIO_NOSUBTITLES (at least as far as
 the "Text and speech" setting goes).
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/16720#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM