[Scummvm-tracker] [ScummVM :: Bugs] #17284: MADS: Forest: The chicory is not described as "a useful herb"

[ScummVM :: Bugs]

#17284: MADS: Forest: The chicory is not described as "a useful herb"
-------------------------+---------------------------------
Reporter:  eriktorbjorn  |       Owner:  dreammaster
    Type:  defect        |      Status:  pending
Priority:  normal        |   Component:  Engine: MADS
 Version:                |  Resolution:  worksforme
Keywords:                |        Game:  Once Upon a Forest
-------------------------+---------------------------------
Comment (by fusefib):

 I traced this against the original DOS overlay and animation asset. The
 ScummVM room logic is basically faithful; the bug is a race already
 present in room 201.

 `RM201F1.AA` has 10 frames, so frame 10 is the completion sentinel, not a
 real frame. The script nevertheless tries to hold there while waiting for
 the 30-tick delay. Depending on which frame the animation is on when the
 first line finishes, completion trigger 102 can fire first and disable
 `anim4()`, leaving state 29 unreachable. That also explains why Valgrind
 makes it work more reliably.

 Room 303 avoids this because its equivalent hold happens before the end of
 the animation.

 A narrow fix that hopefully Just Works is to reset F1 to frame 4 when
 entering case 28, so the 30-tick trigger reliably wins without changing
 the shared animation code to account for this.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/17284#comment:10>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM