[Scummvm-tracker] [ScummVM :: Bugs] #17293: MADS: Forest: Snake's voice line cut off

[ScummVM :: Bugs]

#17293: MADS: Forest: Snake's voice line cut off
-------------------------+---------------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: MADS
 Version:                |  Resolution:
Keywords:                |        Game:  Once Upon a Forest
-------------------------+---------------------------------
Comment (by fusefib):

 Seems an off-by-one. Plox test.

 In ScummVM, `room_308_anim24()` handles the relevant frames one frame too
 early: T007 starts at 19, the holding loop covers 20-25, S308_003 starts
 at 27, and the MIDI transition is at 28. Retail instead uses 20, 21-26,
 28, and 29 respectively.

 While the snake is speaking, it does: `imath_random(20, 25)` which is
 inclusive. In the current code, if it chooses 25 (`1 - (5/6)^n` for `n`
 iterations), the animation advances to 26, escapes the hold, reaches 27,
 and starts `S308_003` on the same speech channel while T007 is still
 playing. That is why "Sebastian on sabbatical" would be cut off
 intermittently.

 MADS: FOREST: Restore native frame tests for room 308

 or something.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/17293#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM