[Scummvm-tracker] [ScummVM :: Bugs] #17371: SCUMM: unknown MD5s for Italian "Ultimate Talkie Edition" of Monkey Island 1 and 2 (detected as CD / DOS instead of SE Talkie)

[ScummVM :: Bugs]

#17371: SCUMM: unknown MD5s for Italian "Ultimate Talkie Edition" of Monkey Island
1 and 2 (detected as CD / DOS instead of SE Talkie)
-------------------------+-------------------------------------------------
Reporter:  jenergy       |      Owner:  (none)
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  Engine: SCUMM
 Version:                |   Keywords:  Monkey Island 1 and Monkey Island 2
    Game:  Monkey        |
  Island 2               |
-------------------------+-------------------------------------------------
 Hi,
 ScummVM 2026.1.0 (Batocera Linux) reports my two Ultimate Talkie builds as
 unknown
 ("Your game version appears to be unknown" / "No unique game candidate
 found,
 using first one"). Because the MD5s are not in scumm-md5.h, detection
 falls back
 to the first variant in the table: "CD" for monkey and "" (DOS) for
 monkey2,
 instead of "SE Talkie". As a result GF_ULTIMATE_TALKIE is not set (the
 Ultimate
 Talkie specific workarounds are skipped) and some workarounds meant for
 the
 original scripts are applied to the patched scripts. `scummvm --detect` on
 both
 folders lists "SE Talkie" as the last candidate.

 Both are Italian builds, latest versions available:

 1) The Secret of Monkey Island - Ultimate Talkie Edition v1.02, Italian
    file: MONKEY.000, size 9135, MD5 b491354a66a6ffce4064b5cfb824b8e9
    speech: monkey.sof (FLAC build)

 2) Monkey Island 2: LeChuck's Revenge - Ultimate Talkie Edition v0.2 beta,
 Italian
    file: MONKEY2.000, size 10835, MD5 4e3d951f396b2bdbfb7db7e4e3fe0aec
    speech: monster.sou (VOC build)

 Suggested entries for scumm-md5.h:
   { "b491354a66a6ffce4064b5cfb824b8e9", "monkey",  "SE Talkie",
 "Unofficial SE Talkie v1.02", 9135,  Common::IT_ITA, Common::kPlatformDOS
 },
   { "4e3d951f396b2bdbfb7db7e4e3fe0aec", "monkey2", "SE Talkie",
 "Unofficial SE Talkie v0.2",  10835, Common::IT_ITA, Common::kPlatformDOS
 },

 The games were built from my own purchased copies (Special Edition on
 Steam and GOG).

 Note on MONKEY2.001 (does not affect the MD5 above, which is computed on
 MONKEY2.000):
 while checking the files I found a resource size error produced by the MI2
 builder.
 In room 27 ("wharf"), the OBIM block of object 263 ("il poster") contains
 IMHD, IM01
 (914 bytes) and IM02, but the IM02 header declares 1734 bytes instead of
 the real 820
 (SMAP 788 + ZP01 24, ending exactly at the end of the OBIM). 1734 = 820 +
 914, so the
 builder apparently added the size of IM01 to IM02. In the Italian original
 (LucasArts
 CD/floppy) the same object has IM01 772 / IM02 624 with correct sizes.
 I patched my copy (2 bytes at file offset 0x21C1B6, value 1734 -> 820
 before the
 0x69 XOR), so my MONKEY2.001 no longer matches the builder output:
   original builder output: MD5 4091762bac700c6ef322e7fd9566b27d
   patched:                 MD5 542c82b1ef41368d5ccda2c05708362c
 Everything else in both games checked out: all speech references in the
 scripts
 point to valid entries in monster.sou / monkey.sof, and all 4393 FLAC
 streams in
 monkey.sof pass their MD5/CRC checks.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/17371>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM