[Scummvm-tracker] [ScummVM :: Bugs] #17421: KYRA: Kyra 1 floppy: Wrongly lit rooms in fireberry maze when turned into will-o-wisp

[ScummVM :: Bugs]

#17421: KYRA: Kyra 1 floppy: Wrongly lit rooms in fireberry maze when turned into
will-o-wisp
-------------------------+--------------------------
Reporter:  eriktorbjorn  |      Owner:  (none)
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  Engine: Kyra
 Version:                |   Keywords:
    Game:  Kyrandia 1    |
-------------------------+--------------------------
 When Brandon turns into a will-o-wisp, what was previously dark rooms in
 the fireberry maze are lit by a purple glow. However, in some rooms this
 glow isn't applied when playing the floppy version of the game.

 I think this is because the maze added a couple of bushes in later
 versions. We have a special case for that in
 `o1_findBrightestFireberry()`, but it seems we also need that in
 `o1_setFireberryGlowPalette()`.

 On a related note, when the will-o-wisp spell wears off the room stays
 lit. I don't know if that's an original glitch or not.

 I'm attaching a savegame at the Cavern of Twilight. That should make it
 easy to reproduce, since one of the rooms where a fireberry bush was added
 is nearby.

 Here is a map I drew of the maze long ago:

 {{{
             O-  O-?-O-O-O-O
                 | | |   | |
             2 O-O-O-O-3-*-O-O-O     #
             | | | | |   | | | |     |
       *     O-O O-*-O-O #-O-?-O-O-*-O
       |     | | | | |   |   | | | |
      -O-*-1-* O-#-O-O O-O #-O-O-6 O
               | | |   | | | | | | |
               *-O O O-* O *-O *-O O-O
               | | | | | | |
               O-O-?-O-O O-O-O-?-O *
                 | | | |     | | | |
                 O-O-O-O-4-*-O-O O-5
                       |   |
                       O-O-O

 * Fireberry bush
 ? Fireberry bush in CD/Mac versions
 # Heavy rock

 1 Treacherous Crossing
 2 The Chasm of Everfall
 3 The Pantheon of Moonlight
 4 The Cavern of Twilight (gold coin, heavy rock)
 5 A subterranean, volcanic river (iron key on other side)
 6 A cavern of emeralds
 }}}

 I think this is how the rooms are numbered:

 {{{
                        126-133-139-146-152-158
                         |   |   |       |   |
                114 122-127-134-140-111-191-159-164-170         184
                 |   |   |   |   |       |   |   |   |           |
    196         121-123 128-189-141-147 153-160-165-171-175-195-185
     |           |   |   |   |   |       |       |   |   |   |
    109-197-115-187 124-129-135-142 148-154 161-166-172-113 179
                     |   |   |       |   |   |   |   |   |   |
                    188-130 136 143-190 155 192-167 194-183 180-186
                     |   |   |   |   |   |   |
                    125-131-137-144-149 156-162-168-173-176 198
                         |   |   |   |           |   |   |   |
                        132-138-145-150-110-193-169-174 177-117
                                     |       |
                                    151-157-163
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/17421>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM