[Scummvm-devel] Re: CD sound interface

[J.Brown (Ender/Amigo)]

That's exactly what we are trying to do - mostly split the source files
and EXPECIALLY the Scumm struct into a series of smaller, easier to
understand classes.

I'm planning to actually make the code work polymorphic, something like
this:

  Scumm OurGame;
  ... blah blah.. detect game.. blah blah..
  select(version) {
	case 3:
		OurGame = new Scumm_V3;
	....
	case 8:
		OurGame = new Scumm_V8;
 }

Where Scumm_V(x) will be child classes of Scumm... I think the idea is
sound, but I'm not quite sure.. it's hard enough trying to split all the
stuff in Scumm into what goes where!

Regards,        | It's always bad news in computing.. and beware
		| of anything claming to be good news - because
                | its probably a virus. - Salmon Days
        Ender   |
  (James Brown) | [Nehahra, EasyCuts, PureLS, www.QuakeSrc.org]

On Wed, 20 Mar 2002, Ruediger Hanke wrote:

> Date: Wed, 20 Mar 2002 16:08:05 +0100
> From: Ruediger Hanke <tomjoad at muenster.de>
> To: Scummvm-devel at lists.sourceforge.net
> Subject: [Scummvm-devel] Re: CD sound interface
>
> > Maybe you should wait for the end of the code freeze since all the low
> > level access (including cd track access) are going to be redesigned ....
>
> I don't know how much redesign you have planned, but I'd like
> to encourage you to whatever you redesign - do it thoroughly.
> I'm some kind of OOP guru, and, well, ScummVM is more or less
> pseudo-OOP by now. Most of the struct xyz (xyz = Actor, ...) should
> really be classes with their own methods, the MIDI drivers just scream
> out for this. The class "Scumm" contains way too many and diverse
> functions. This actually has a name, it's a design anti pattern known
> as "The Blob" (one class dominates the program flow, utilizing several
> data structures, bad coherence).
>
> And while most is contained in the classes, strangely the
> OS interface functions (initGraphics, blitToScreen) are not.
>
> Sorry if I sound like a teacher here, I do criticize a lot of my own
> stuff as well if that's a comfort ;-) I just mention it because I think
> it would help keeping ScummVM maintainable.
>
> Rüdiger
> --
> "...wherever there's somebody fightin' for a place to stand
> Or a decent job or a helping hand
> Wherever somebody's struggling to be free
> Look in their eyes Mom you'll see me."
> - Bruce Springsteen, "The Ghost of Tom Joad"
>
>
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel
>