[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/sky adlibchannel.h,1.1,1.2 adlibchannel.cpp,1.1,1.2 adlibmusic.cpp,1.1,1.2 adlibmusic.h,1.1,1.2

[Max Horn]

Am Samstag, 10.05.03 um 07:26 Uhr schrieb J.Brown (Ender):

> I suggest reverting to the old code in head cvs also. I've already 
> vetoed
> this code being used in ScummVM at least three times in the past

Uh, you vetoed it in the past? Never knew that. I only know that in the 
past we couldn't use the new fmopl code due to licensing issues with 
MAME, which are not a problem anymore, since we can get the code as GPL 
or LGP as we need.

Could you please point out any references where you vetoed it in my 
presence (scummvm-devel emails or IRC logs) ?


> - the
> overhead is pretty high for something which only sounds very very 
> slightly
> better.
>
To me it sounds quite some better. Plus its timing is much more 
accurate, which makes a difference for e.g. the MonkeyVGA intro music, 
which has the right length with the new fmopl but is too fast with the 
old.

The processor overhead is not more than the old fmopl, I think, and 
even if it is, both are noticable on a current machine. And both are 
too slow for low end machines like certain WinCE devices (see arisme's 
post); the only reason the old fmopl code was "better" there is that 
it's easy to hack it to use less CPU power at the expense of quality.

To me, it would seem to be the logical choice to first attempt to make 
the same trick with the new fmopl: in case that fails, simply use the 
new fmopl for everything except the WinCE port (and maybe GP32 / 
PalmOS, if needed).


Max