[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/sky adlibchannel.h,1.1,1.2 adlibchannel.cpp,1.1,1.2 adlibmusic.cpp,1.1,1.2 adlibmusic.h,1.1,1.2

[Max Horn]

Am Samstag, 10.05.03 um 14:19 Uhr schrieb Arisme:

>> How can a game not using adlib be slowed down, if we don't even call
>> any function of fmopl.cpp in that case?
>>
>
> we always call premix_proc in the mixer, which will call 
> generate_samples
> and YM3812UpdateOne thus advancex - that's why I said that the games 
> are
> slowed down by the clock emulation and not by the sample generation ...

Still, that only happens when the adlib driver is used, no? I don't see 
how it can always happen, as you claim, but maybe I miss something 
obvious? If you use e.g. -enull, it shouldn't be an issue at all, as I 
read the code.


> (one fix for that would be to stop calling create_midi for games that 
> don't
> need it such as Loom CD, but I don't think this is the main issue here 
> :))

That would be the wrong way to do it. If at all, one should default to 
the null midi driver for those games.

Still, I don't see a problem in making backends/midi/adlib.cpp use the 
old fmopl code alternatively if that's needed.


Max