[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: residual smush.cpp,1.36,1.37 smush.h,1.18,1.19 timer.cpp,1.4,1.5 timer.h,1.2,1.3

[Max Horn]

Am 26.03.2004 um 23:37 schrieb Pawel Kolodziejski:

> Update of /cvsroot/scummvm/residual
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv14105
>
> Modified Files:
> 	smush.cpp smush.h timer.cpp timer.h
> Log Message:
> timer stack locks are now usefull for smush code
>

Uhhh ???? This change makes absolutely no sense to me. Would you mind 
and explain what exactly you think it does which the original code 
didn't do already? As far as I can tell, the only thing it does is to 
lock the mutex *twice* instead of just once, that's all. No additional 
protection granted, only additional possibilities of a dead lock on 
systems which don't allow a thread to lock a mutex twice.


Exposing the Timer' classes mutex seems like a bad design decision. At 
most we'd have Timer::lock() / Timer::unlock() methods; however, right 
now I don't see any reason to do that either.



Bye,

Max