[Scummvm-devel] HQ scalers in i386 assembly

[Torbjorn.E.Andersson at tietoenator.com]

Eugene Sandulenko wrote:

> Now I would like to ask your opinion, is this code worth to go to CVS? It
> is be optional, i.e. it compiles old C code on non-Intel platforms. I
> still have to modify configure script, so it will be autodetected which
> version should be compiled, but before I put efforts into that I would
> like to hear your opinion.

I don't have any problem with having platform-specific optimized versions of
functions, provided that

A) There is a cross-platform version to fall back on.
B) There is a noticeable performance gain.
C) It doesn't complicate the rest of the code too much.

'A' is clearly not a problem in this case. 'B' is subjective, but from what
you say it's not even close to a problem. 'C' is also subjective, but I
trust it won't be a problem either.

So, as far as I'm concerned, go for it! :-)

(Of course, someone else may still veto it.)

Torbjörn

-- 
TietoEnator Resource Management AB
Persona
Torbjörn Andersson
http://www.rm.tietoenator.com/