[Scummvm-devel] Re: [Scummvm-cvs-logs] SF.net SVN: scummvm: [20967] scummvm/trunk/engines/scumm/script_v5.cpp

Max Horn max at quendi.de
Tue Feb 28 00:51:07 CET 2006


Am 28.02.2006 um 09:40 schrieb Max Horn:

>
> Am 28.02.2006 um 02:14 schrieb kirben at users.sourceforge.net:
>
>> Revision: 20967
>> Author:   kirben
>> Date:     2006-02-27 17:14:02 -0800 (Mon, 27 Feb 2006)
>> ViewCVS:  http://svn.sourceforge.net/scummvm?rev=20967&view=rev
>>
>> Log Message:
>> -----------
>> These zakTowns specific changes aren't explained and don't match  
>> original code. If problems still occur, add bug reports with details.
>
>
> You are right, this could have been documented better, but: Please,  
> folks, use the "blame" feature of subversion next time to find out  
> who made a given change and why, and then ask those people about it  
> -- that's often more useful than just removing it, although it  
> means a little bit more work for you :-).
>
> In this particular case, it took me five minutes to do so, by first  
> surfing to <https://svn.sourceforge.net/viewcvs.cgi/scummvm/scummvm/ 
> trunk/engines/scumm/script_v5.cpp?view=log>, then to <https:// 
> svn.sourceforge.net/viewcvs.cgi/scummvm/scummvm/trunk/engines/scumm/ 
> script_v5.cpp?annotate=20795>, then to <https://svn.sourceforge.net/ 
> viewcvs.cgi/scummvm/scummvm/trunk/engines/scumm/script_v5.cpp? 
> view=diff&r1=9649&r2=9650>
>
> And then looking at the commit message for revision 9650 to find  
> out who did the change and why... eriktorbjorn in this case.

Hehe, actually, I stopped a bit early. Of course Torbjörn only moved  
some code which was originally added by me. See revision 8655, the  
commit message being: "fix for 'default talk color' use of actorSet  
opcode (fix for bug #755888)". Looking at that bug report, it seems  
that the original issue has been fixed and the workaround is not long  
necessary. Yippie!

Bad me for not adding a proper WORKAROUND comment back then (but in  
my defense I have to say that this was before I introduced the  
WORKAROUND comment standard to ScummVM :).


Cheers,
Max



More information about the Scummvm-devel mailing list