[Scummvm-devel] START_PACK_STRUCTS default changed -- portbreakage

Torbjörn Andersson eriktorbjorn at telia.com
Sun Jul 23 18:00:41 CEST 2006


While on the subject of packed structs, I noticed that the MT-32
emulator has its own macros for marking a struct as packed in
sound/softsynth/mt32/structures.h. Not only that, but there seems to be
a potential problem with it:

sound/softsynth/mt32/structures.h:154: warning: 'packed' attribute
ignored for field of type 'MT32Emu::TimbreParam [8]'
sound/softsynth/mt32/structures.h:156: warning: 'packed' attribute
ignored for field of type 'MT32Emu::PatchParam [128]'

It also has its own set of 8/16/32/64 bit types.

Should we make it follow the ScummVM way, or should we treat it as a
separate entity? I'm reluctant to touch it since I'm thoroughly
unqualified... sorry, I mean unable, to run it on my hardware.

As a final observation, there was some upstreams activity in the "munt"
project a few weeks ago. I wonder if it's worth a re-sync yet.

Torbjörn





More information about the Scummvm-devel mailing list