[Scummvm-devel] setFocusRectangle() and 192x128...

Gregory Montoir cyx at users.sourceforge.net
Fri Dec 7 22:06:00 CET 2007


Hi,

I'm about to add or modify setFocusRectangle() in queen and touche 
engines but I wonder where the rect dimensions (192,128) that 
scumm/sky/sword2 engines use are taken from (I suppose it's from the NDS 
video resolution, but asking doesn't hurt)....

system.h mentions this about setFocusRectangle :

* The backend is responsible for clipping the rectangle and deciding how 
best to
* zoom the screen to show any shape and size rectangle the engine provides.

Which just doesn't seem to match with the existing code in the NDS 
backend (the "any size" part, at least the rect width/height aren't 
considered when centering).

Should we add another 2 methods to OSystem (ie. 
getFocusRectangleWidth/Height instead of hard coding 192/128) ; or is it 
really safe to pass any rectangle dimension ?

Gregory





More information about the Scummvm-devel mailing list