[Scummvm-devel] Simon the Sorcerer appears to leak all it's audio ram

[Travis Howell]

From: "Neil Millstone" <neil at millstone.demon.co.uk>
> Except for one thing: I put in some guards to prevent some of the huge
> speech samples that Simon 1 uses from crashing the game.  I made it so
> that the sound doesn't play if the malloc() call fails to allocate
> memory.  This doesn't seem to have been retained now that the code has
> been reorganised, so I will need to put something similar in again.

That code was removed, due to been a bad hack, and shouldn't be added back 
again. It could cause a situation where no speech is played and no subtitles 
are shown, so the user has no idea what happened. Combined speech and 
subtitles isn't possible in the English and German versions of Simon the 
Sorcerer 1. And you can't be sure, that subtitles are enabled in other games 
either.

> Eventually I think we should consider streaming these sounds rather than
> loading them all in one go.  There's one sample near the beginning
> that's 900Kb!

Yes, that would be the best method, and patches are welcome.