[Scummvm-devel] Simon the Sorcerer appears to leak all it's audio ram

[Eugene Sandulenko]

On Mon, 4 Jun 2007 15:33:32 +0200 (CEST)
"Max Horn" <max at quendi.de> wrote:

> 1) Neil's way, which silently ignores if a failure occurs to load a
> sound (this change would be inside an #ifdef DS, of course). Kirben
> is opposed to this, quoting additional bug reports which would
> supposedly turn up. Kirben, can you please elaborate a bit on this --
> what kind of bugs would crop up due to this?
Neil's approach is to do not attempt playing speech when malloc() of
speech buffer fails. This is really bad and is unacceptable because in
simon1 CD there are no subtitles. That means that with this hack some
sentences will be just silently skipped without any knowledge of the
user, so the user may lost track of what's going on.

Imagine situation when some item description will not fit in DS memory.
I mean voice over. There are no subtitles. So any user's attempt to
hear that description will produce no result. Is that good?


Eugene