[Scummvm-devel] Augmented target name

[Johannes Schickel]

On Monday 07 April 2008 16:13:01 Max Horn wrote:
> * Add some more flags for CD/floppy/??? variants. This would require the
> least code changes, but would be rather inflexible
> * switch to multiple gameids after all. another simple "solution", but ugly.
> * add a new field "const char *variant" to ADGameDescription, set to 0 by
> default. Most flexible, but requires updating all engines which use the
> AdvDetector (not hard, though, just tedious ;)
> 
> So far, the third option seems to me by far the best. But maybe somebody
> has a better idea?

Third sounds fine with me too.

> > Also about multilanguage games, HoF supports language selection via
> > ingame menu. How do I update the language without the need to fear
> > that the target id was kyra1-cd-de in the beginning and now stays the same
> > though I changed it to french?
> 
> Hm, normally, the detector should detect this as a game with language
> "unknown" (we could add a "multi-lingual" flag in the future, though i see
> little use for that). The generated target name hence would not carry any
> language. Switching the "language" setting would not affect this, so I see
> no risk.
> Or maybe I misunderstood you?

Well last time I checked if I only had an entry with "unknown" as language
setting and the user manually set the language, it would not be detected
by AdvancedDetector anymore, but maybe that was fixed. So I would have
to add language specific entries which would then have those arugmented
target names and that is bad for multi language games then IMHO.

> > Also I remember about a
> > discussion 'caused by our event recoder not supporting kyra, just
> > because kyra used the OSystem event API in a valid way, which
> > was not expected when writing that event recorder code.
> > ('valid' as in conforming to the documentation).
> 
> Can't comment on that, as I was not privy to this (or if I was, I totally
> forgot). Can you point me to an IRC log or so?

Hm could be that it was a private conversation, would have to check
my IRC logs about details.

// Johannes