[Scummvm-devel] Augmented target name

[Max Horn]

Am Mo, 7.04.2008, 17:02, schrieb Johannes Schickel:

>> > Also about multilanguage games, HoF supports language selection via
>> > ingame menu. How do I update the language without the need to fear
>> > that the target id was kyra1-cd-de in the beginning and now stays the
>> same
>> > though I changed it to french?
>>
>> Hm, normally, the detector should detect this as a game with language
>> "unknown" (we could add a "multi-lingual" flag in the future, though i
>> see
>> little use for that). The generated target name hence would not carry
>> any
>> language. Switching the "language" setting would not affect this, so I
>> see
>> no risk.
>> Or maybe I misunderstood you?
>
> Well last time I checked if I only had an entry with "unknown" as language
> setting and the user manually set the language, it would not be detected
> by AdvancedDetector anymore, but maybe that was fixed. So I would have
> to add language specific entries which would then have those arugmented
> target names and that is bad for multi language games then IMHO.
>

Eek, that sounds like a bug / misfeature to me. The attached patch should
(hopefully) fix it. If it helps, and nobody (Eugene?) objects, we could
just commit it.

Cheers,
Max
-------------- next part --------------
A non-text attachment was scrubbed...
Name: advdetect-language.patch
Type: text/x-patch
Size: 668 bytes
Desc: not available
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20080407/f82cfd4c/attachment.bin>