[Scummvm-devel] Augmented target name

[Johannes Schickel]

On Monday 07 April 2008 17:35:19 Max Horn wrote:
> Eek, that sounds like a bug / misfeature to me. The attached patch should
> (hopefully) fix it. If it helps, and nobody (Eugene?) objects, we could
> just commit it.
> 
> Cheers,
> Max

That fixed it, now the variant thingie would be missing and I would
switch to argumented target ids.

Btw. without that patch I get a segmentation fault when setting a language
on my own and having just an entry with UNK_LANG:

Looking for kyra2
Trying to start game 'The Legend of Kyrandia: The Hand of Fate'
Your game version appears to be unknown. Please, report the following
data to the ScummVM team along with name of the game you tried to add
and its version/language/etc.:
  "fate.pak", "28cbad1c5bf06b2d3825ae57d760d032", 113449

WARNING: Legend of Kyrandia Engine failed to instantiate engine: Unable to locate game data (target 'kyra2cdger', path '/home/[...]/scummvm/kyra2cd/')!
WARNING: Config 'modern' is NOT usable for themes or not found!
WARNING: falling back to classic style!

Program received signal SIGSEGV, Segmentation fault.

[Switching to Thread 0x2af7137573a0 (LWP 4819)]
0x00000000004536b6 in OSystem_SDL::RGBToColor (this=0x7a8010, r=0 '\0', g=0 '\0', b=0 '\0') at backends/platform/sdl/graphics.cpp:1232
1232            return SDL_MapRGB(_overlayscreen->format, r, g, b);
(gdb) bt
#0  0x00000000004536b6 in OSystem_SDL::RGBToColor (this=0x7a8010, r=0 '\0', g=0 '\0', b=0 '\0') at backends/platform/sdl/graphics.cpp:1232
#1  0x0000000000495d4a in GUI::ThemeClassic::init (this=0x8ce5c0) at gui/ThemeClassic.cpp:78
#2  0x000000000047fe93 in NewGui (this=0x8cc840) at gui/newgui.cpp:115
#3  0x000000000045b38a in Common::Singleton<GUI::NewGui>::makeInstance () at ./common/singleton.h:57
#4  0x000000000045b3ba in Common::Singleton<GUI::NewGui>::instance () at ./common/singleton.h:71
#5  0x000000000045a8f7 in scummvm_main (argc=2, argv=0x7fff9a6097c8) at base/main.cpp:335
#6  0x00000000004575a8 in main (argc=2, argv=0x7fff9a6097c8) at backends/platform/sdl/main.cpp:108