[Scummvm-devel] Progress with Archive & SearchManager

Filippos K philipk79 at hotmail.com
Thu Oct 2 11:21:01 CEST 2008


I disagree that ScummVM is broken under Windows after Max's commit. If a user sets the theme path correctly (which he should), everything works as expected. Perhaps this might give users a better incentive to actually *set* the theme/extras/save paths to something viable, and we might not have users in the future who complain that ScummVM can't save or crashes during saving.

All in all, I agree with Max and think that we should *not* fall back to the current directory. This saves us from "weird" errors such as, for example, engine data files (e.g. kyra.dat) with different versions, stored in ScummVM's folder, inside the game's folder and inside the extras folder

ScummVM works perfectly under Windows XP and Vista for me right now, and I don't see why we should add that hack back to please lazy users who don't want to change ScummVM's paths

Just my 2c
Filippos

> Date: Wed, 1 Oct 2008 10:07:20 +1000
> From: kirben at optusnet.com.au
> To: max at quendi.de
> CC: scummvm-devel at lists.sourceforge.net
> Subject: Re: [Scummvm-devel] Progress with Archive & SearchManager
> 
> Max Horn wrote:
> > By following this approach, it gets easier to migrate Engines  
> > *gradually* away from the File::addDefaultDirectory() API. This would  
> > be the next step. First, convert File::addDefaultDirectory calls. Then  
> > replace anything which does "new File" to use SearchMan::openFile  
> > instead. Finally, consider replacing all uses of File (but let's not  
> > rush that). Oh yeah, one thing we must watch out here is that class  
> > File has a hack which makes it identify the filenames "FOO" and  
> > "FOO."; this is, AFAICT, for Simon's GAMEPC file only, so my hope is  
> > that we can push this hack to the AGOS engine.
> 
> Unfortunately this problem effects all data files in Simon the Sorcerer 
> 1/2 (CD), that don't use a file extension. Under a unix system, any 
> filename without a file extension on the CD, shows up with an additional 
> '.' at the end.
> 
> fingolfin at users.sourceforge.net wrote:
>  > Revision: 34680
>  >           http://scummvm.svn.sourceforge.net/scummvm/?rev=34680&view=rev
>  > Author:   fingolfin
>  > Date:     2008-09-29 10:32:06 +0000 (Mon, 29 Sep 2008)
>  >
>  > Log Message:
>  > -----------
>  > File::open no longer falls back to searching the current dir (if this 
> causes any regressions, please report them; don't work around them, 
> don't revert this change, without discussing it first)
> 
> This breaks the external files (engine data and theme files) under the 
> Windows port, since those files are stored in the same directory as the 
> ScummVM.
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel

_________________________________________________________________
See how Windows Mobile brings your life together—at home, work, or on the go.
http://clk.atdmt.com/MRT/go/msnnkwxp1020093182mrt/direct/01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20081002/d7c7c6e7/attachment.html>


More information about the Scummvm-devel mailing list