[Scummvm-devel] Progress with Archive & SearchManager

[Travis Howell]

Filippos K wrote:
>  > No, it doesn't work as expect at all. The default theme fails to load,
>  > along with any game requiring an engine data file.
> 
> The default theme (aka the "Classic" theme) doesn't need any external 
> files to load - only the modern one does. If the theme path is set 
> correctly, the modern theme is set correctly

Well the modern theme is meant to be the default, where supported.

>  > Why should a user have to set any extra or theme path, unless required
>  > (ie custom theme, sharing data files) ?
>  >
>  > The save game path is a separate issue, there is no default location for
>  > saved games under Windows. And I have mention adding a option, to prompt
>  > for the save path location, if it has not been set before.
>  >
> 
> The save game path is actually the same issue as the other ones. Both 
> the theme and save game path should be set to something viable

Why should the theme path need to be set though? I don't think any port 
currently sets the theme path in the config file.

>  > Actually the problem is usually a person has an older engine data file,
>  > with the game's data files.
> 
> No, the same problem can be caused if an older version of an engine data 
> file is in ScummVM's folder, and a newer one in the "extras" path, which 
> can be avoided if ScummVM does not check the current folder by default

Considering the current directory is only checked as the last option, I 
don't see how that could actually occur at all.

>  > Under Windows, all essential files, are usually stored with the
>  > executable file.
> 
> This is usually the case with the other ports

Actually the engine data files and theme are stored in different 
location, on any Unix based ports.

>  > Other ports of ScummVM used a default data files path, where the engine
>  > data files and theme files are stored.
>  >
>  > The default data files path could be set to the current working
>  > directory, for the Windows port only.
> 
> Why add a Windows-only hack, when the behavior should be exactly the 
> same as with other ports?

Other ports (Unix based) already set a default path (via DATA_PATH 
define), for the location of engine data files and theme.

So why is setting that default path, to the current working directory, 
under Windows port any different?