[Scummvm-devel] Progress with Archive & SearchManager

[Johannes Schickel]

On Thursday 02 October 2008 13:10:32 Travis Howell wrote:
> Filippos K wrote:
> > The default theme (aka the "Classic" theme) doesn't need any external
> > files to load - only the modern one does. If the theme path is set
> > correctly, the modern theme is set correctly
>
> Well the modern theme is meant to be the default, where supported.

Agreed, modern theme should be default. Which it is by default configuration 
anyway, isn't it?

> >  > Actually the problem is usually a person has an older engine data
> >  > file, with the game's data files.
> >
> > No, the same problem can be caused if an older version of an engine data
> > file is in ScummVM's folder, and a newer one in the "extras" path, which
> > can be avoided if ScummVM does not check the current folder by default

Actually for Kyra I'm thinking of checking *all* kyra.dat files found for 
being the correct version in the future.

> >  > Other ports of ScummVM used a default data files path, where the
> >  > engine data files and theme files are stored.
> >  >
> >  > The default data files path could be set to the current working
> >  > directory, for the Windows port only.
> >
> > Why add a Windows-only hack, when the behavior should be exactly the
> > same as with other ports?
>
> Other ports (Unix based) already set a default path (via DATA_PATH
> define), for the location of engine data files and theme.
>
> So why is setting that default path, to the current working directory,
> under Windows port any different?

AFAIK we have two different options for Windows: Keep all files in the  
executable path (or rather said cwd aka '.', which depending on the user's 
configuration might not be the executable path) or bundle them as resources 
in the executable. From what I get both should be easy to achieve with our 
OSystem::addSysArchivesToSearchSet method. I'm unsure with which option we 
want to go there though.

// Johannes