[Scummvm-devel] RTL branch to be merged (relevant for *all* developers)

[Chris Page]

Hey everyone, sorry if I am a bit late coming into this discussion, I've
been a little busy.

Great points made so far, especially about making the RTL code more
transparent by moving the shouldRTL() check.

About the AGI thing:

At first, it looked to me like quitProgNow is simply an integer used as a
flag for whether or not the engine should quit.  However, I guess it was
used for more than that.

Concerning the place in the game where quitProgNow was originally set to
"0xff" (op_cmd.cpp:1234), I think this is equivalent to setting it to "1" or
"true", right?  The value "true" was also originally used to set quitProgNow
earlier in the file (op_cmd.cpp:1216 and 1220).  Also in cycle.cpp line 317,
where quitProgNow was originally initialized, "false" was used.  I'm fairly
certain that returning a boolean "true" or "false" achieves the same effect
as returning an integer "1" or "0", respectively.

Please correct me if I'm wrong on any of this.

Thanks to everyone for their input so far, and helping to get the RTL branch
merged smoothly!

Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20080903/3cf16214/attachment.html>