[Scummvm-devel] PORTERS: Slight DISABLE_FANCY_THEMES handling change.

[Lars Persson]

Hi!

But this code is still left in VectorRenderer.h

 

// To assure we have VECTOR_RENDERER_FORMAT specified when
// DISABLE_FANCY_THEMES is defined, we error out elsewise
#if defined(DISABLE_FANCY_THEMES) && !defined(VECTOR_RENDERER_FORMAT)
#error "You need to specify a fixed overlay format via VECTOR_RENDERER_FORMAT"
#endif

 

I guess that should also be removed before we can remove VECTOR_RENDERER_FORMAT or?

 

Cheers

Lars
 
> Date: Mon, 16 Feb 2009 23:17:41 +0100
> From: lordhoto at gmail.com
> To: scummvm-devel at lists.sourceforge.net
> Subject: [Scummvm-devel] PORTERS: Slight DISABLE_FANCY_THEMES handling change.
> 
> Hi,
> 
> First of all if your port does not define DISABLE_FANCY_THEMES this mail 
> is probably not really useful for you.
> 
> You might have noticed that in trunk we switched our GUI renderer from 
> an pure template based approach, means taking an template parameter for 
> pixel format description, to an implementation, which takes a 
> Graphics::PixelFormat describing the pixel format as constructor 
> parameter. This allows us to support various different pixel formats 
> without any additionally generated code.
> 
> This removes the need for VECTOR_RENDERER_FORMAT on platforms where 
> DISABLE_FANCY_THEMES is defined, since now for every system we can 
> safely use OSystem::getOverlayPixelFormat to pass it to the 
> VectorRenderer. Thus everyone defining VECTOR_RENDERER_FORMAT can now 
> safely remove it.
> 
> // Johannes
> 
> PS: If you want to check out the commit removing VECTOR_RENDERER_FORMAT 
> check diffs for r38381.
> 
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
> -Strategies to boost innovation and cut costs with open source participation
> -Receive a $600 discount off the registration fee with the source code: SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel

_________________________________________________________________
Connect to the next generation of MSN Messenger 
http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source=wlmailtagline
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090217/550100a5/attachment.html>