[Scummvm-devel] Gettring rid of ioFailed

[Max Horn]

Hi folks,

I would like to propose that we try to get rid of the  
SeekableReadStream::ioFailed() method very soon now. Instead, eos()  
and err() should be used as appropriate. Luckily, not many files are  
affected anymore. Other than our engines, only these five non-engine  
files seem to use ioFailed:

   graphics/font.cpp
   graphics/video/coktelvideo/coktelvideo.cpp
   graphics/video/mpeg_player.cpp
   sound/aiff.cpp
   sound/flac.cpp

The only thing is that I am somewhat wary to do this prior to  
branching; but there is at least one regression related to this that I  
need to fix anyway, so I'll probably do this in SCUMM tonight. See <https://sourceforge.net/support/tracker.php?aid=2820957 
 >.

In the meantime, I would like to urge all developers to *not* use  
ioFailed in new code!


Cheers,
Max