[Scummvm-devel] Break save game compatibility in SCUMM game engine

[Norbert Lange]

I would like to see if atleast some of the path issues that apparently  
occur in Windows (http://forums.scummvm.org/viewtopic.php?t=7628) would be  
fixed. Should default to the same directory the config-file gets generated.

And related to that the code to determine the place for the config file is  
a bit messy aswell. There are functions that work with practically any  
32-bit Windows out there (excluding only Win95/WinNT without IE4+).

The required change would be in
sdl.cpp, Function getDefaultConfigFileName

and would look like this:

char configFile[MAX_PATH];
SHGetSpecialFolderPathA(NULL, configFile, CSIDL_APPDATA, TRUE);
strcat(configFile, "\\ScummVM");
CreateDirectory(configFile, NULL);
strcat(configFile, "\\" DEFAULT_CONFIG_FILE);

Downside ofcourse would be that old config-files have to be moved on some  
Windows Versions (I guess only Win9x), and some really dead Versions  
wouldnt run with complaining about a missing "shell32.dll" - and this  
could be fixed by installing IE4 or newer.
Optionally we could do a fallback by checking for shell32.dll but I dont  
think its worth it

Regards, Norbert

Am 14.07.2009, 06:07 Uhr, schrieb Travis Howell <kirben at optusnet.com.au>:

> Eugene Sandulenko wrote:
>> We need to discuss this change in a separate thread and come with less
>> intrusive solution if possible.
>
> Splitting into separate subject, as requested.
>
> I propose to completely break compatibility with old save games in the
> SCUMM game engine, in order to clean up various code, that has been
> limited due to keeping compatibility with older saved games.
>
> Specifically to make the following changes, if agreed to:
> * Compile a list (on wiki?) of all changes that would be made to SCUMM
> engine.
> * Completely drop compatibility for older save games.
> * Take time (few weeks?) to clean up and improve code of the SCUMM game
> engine (without the current limitations, imposed by keeping
> compatibility with older saved game).
> * Only offer save game compatibility from that point (ie ScummVM 1.0)
> onwards. Maybe start with save game version 100, and display GUI message
> if person attempts to load an older saved game.
>
> If agreed to, I think these changes, would be best made shortly before
> the release cycle for the first major release (ScummVM 1.0).
>
> I'm especially interested in feedback from Max, who had to work around
> these limitations many times in the past, and would have better idea of
> what code improvements could be made.
>
> Eugene Sandulenko wrote:
>> The question is who will implement this?
>
> I can help compile list of changes required, and help with those code
> changes.
>
>
>
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full  
> prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel