[Scummvm-devel] Bitdepth/pixel format API concerns

[Max Horn]

Am 11.06.2009 um 11:58 schrieb J Northup:
>
> Now, if I take Eugene's recommendation (from IRC) that color order  
> passed from engine to backend is always RGBA, then removing the  
> ability from the engines to specify their own order is actually a  
> plus, as it shields from potential future developer error. But, I  
> don't know if that idea is universally agreed upon.

I disagree with it, for one. If we follow that course, then there will  
in very many cases be two conversions taking place: Once inside the  
engine, once inside the backend.

Let the engine use its native format, let the backend worry about  
translating that to whatever native format it has. And if an engine  
wants to be funky, let it by letting it query available formats --  
something that is *not* difficult, it's fairly easy in fact. Granted,  
it is more work than not doing anything, but then not adding support  
for 16bit games is also a lot easier than not adding it, right? :)

So far, I see no actual cons to using Graphics::PixelFormat -- I think  
LordHoto refuted all claims otherwise so far. Maybe we miss something,  
though -- then I'd like to hear concrete arguments, though ;).


Bye,
Max