[Scummvm-devel] SCI strings

Filippos Karapetis philipk79 at hotmail.com
Sun Sep 27 19:44:32 CEST 2009


Nice work :) Very efficient and clean solution. I'm unsure how the stringfrag
functions would help clean up kEditControl(). Greg's engine has a much nicer
and cleaner solution for that function, which we could use ourselves, which
seems to require no string fragment-related code to work...
(files kernel.cpp and controls.cpp - ControlsMgr::Edit())

Regards
Filippos

> Date: Sun, 27 Sep 2009 02:02:22 +0000
> From: wjp at usecode.org
> To: scummvm-devel at lists.sourceforge.net
> Subject: [Scummvm-devel] SCI strings
> 
> Hi all,
> 
> I've just committed a large update to the SCI engine, converting all string
> handling to work with both raw and reg_t-based segments.
> 
> It's not optimally clean yet, but I thought it would be better to get things
> working first. For now, I've added a set of string utilities to segMan, such as
> 
> strcpy(reg_t dest, reg_t src)
> strcpy(reg_t dest, const char* src)
> getString(reg_t str)
> 
> and a couple of others. This allows the majority of kernel functions to work
> quite cleanly. However, there is still a bunch that are a bit ugly with this
> approach, such as kEditControl.
> 
> I copied a lot of the conversion logic from stringfrag.cpp into those utility
> functions, but didn't delete it from stringfrag.cpp yet. It could be that some
> of the functions in there can be used clean up things like kEditControl.
> 
> 
> I've done some basic testing, and things generally seem to work, including for
> example the password feature in LSL5.
> 
> 
> Comments/improvements/tests would be very welcome :-)
> 
> 
> -Willem Jan
> 
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay 
> ahead of the curve. Join us from November 9-12, 2009. Register now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel
 		 	   		  
_________________________________________________________________
Lauren found her dream laptop. Find the PC that’s right for you.
http://www.microsoft.com/windows/choosepc/?ocid=ftp_val_wl_290
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090927/66aa14b1/attachment.html>


More information about the Scummvm-devel mailing list