[Scummvm-devel] Finding the theme archive via SearchMan

[Johannes Schickel]

On 04/28/2010 10:18 PM, sunmax at libero.it wrote:
> Hi ScummVM Team!
>
>    
>> As Johannes already pointed out, we really do want
>> to be able to use unzipped themes. The best solution
>> seems indeed to accept some code duplication and first
>> only search for unzipped themes (i.e. directories
>> containing theme data files), and then using SearchMan
>> to locate suitable theme .zip files... Unless I am missing
>> something, in which case I am sure otherwise will quickly
>> speak up :)
>>      
> Exactly, here I am ;-)
>
> Could we please first check if there is a .zip in the theme
> path? The point is that scanning a bunch of directories to
> see if there are unzipped themes can be dog-slow on PS2 and
> would ultimately slow down the startup time of ScummVM.
>    

Currently all subdirs of themepath, DATA_PATH, the bundle path (on OS 
X), extrapath (in that order) are searched for any theme files (i.e. 
both zip and directories) and then the "." is searched with a depth of 
1, i.e. just the direct children of that are searched. So what you 
describe as making the PS2 startup ultimately slow is done currently, so 
either we have a really slow start up time on the PS2 or I guess it 
should not change much ;-).

// Johannes