[Scummvm-devel] Finding the theme archive via SearchMan

Max Horn max at quendi.de
Wed Apr 28 22:38:14 CEST 2010


Am 28.04.2010 um 22:18 schrieb sunmax at libero.it:

> Hi ScummVM Team!
> 
>> As Johannes already pointed out, we really do want
>> to be able to use unzipped themes. The best solution 
>> seems indeed to accept some code duplication and first
>> only search for unzipped themes (i.e. directories 
>> containing theme data files), and then using SearchMan
>> to locate suitable theme .zip files... Unless I am missing
>> something, in which case I am sure otherwise will quickly
>> speak up :)
> 
> Exactly, here I am ;-)
> 
> Could we please first check if there is a .zip in the theme
> path? The point is that scanning a bunch of directories to
> see if there are unzipped themes can be dog-slow on PS2 and
> would ultimately slow down the startup time of ScummVM.

Actually, that wouldn't speed up anything, because we'd still search everywhere in order to find *all* available themes -- so that we can show the user a list with them, you know ... ;).

But we could always add an #ifdef allowing ports to disable support for unzipped themes to increase speed, I guess.

Cheers,
Max



More information about the Scummvm-devel mailing list