[Scummvm-devel] Testing needed for GSoC OpenGL Branch
vgvgf
vgvgvgf at gmail.com
Sat Aug 7 01:23:48 CEST 2010
Hi,
On Fri, Aug 6, 2010 at 3:46 AM, Hubert Maier <raziel_nosgoth at web.de> wrote:
>
> It doesn't unfortunately.
> Commenting them out makes the compiler error out on the touche engine later on.
>
> I will attach the error message later, thanks so far
Maybe, with:
#undef KEYCODE_LESS
#undef KEYCODE_GREATER
after includung the SDK header?
On Fri, Aug 6, 2010 at 7:33 AM, yotam barnoy <yotambarnoy at gmail.com> wrote:
>>
>> I know this is a minor comment but is there any chance you could consider
>> adding support for a 5:3 / 5:4 aspect ratios? (I think there may have been
>> some patches hanging about for that on the pre OGL SDL backend).
>>
>> 800*480 is a very popular resolution for the LCD's in a number of portable
>> devices. I guess all the 1280*1024 users would also appreciate the option
>> (after all, they don't have to use it ;-)). I can't say I relish the idea of
>> messing about with the screen setup but it is a popular option with users
>> that often gets raised.
>
> What's the use of supporting all these different aspect ratios in the
> first place? These LCD's will get their own aspect ratio when they go
> fullscreen with stretch-to-fit. As far as I can tell, only 3 options
> are needed: original size, same aspect ratio as the original, and
> stretch-to-fit (either the resizeable window dimensions or the full
> screen). Anything else just seems to complicate matters, no?
I have added 5/3 and 5/4, not many modifications needed to add them.
By default, only "None" (Stretching to fit all window), "Conserve"
(For mantaining the aspect ratio) and the one saved in
"desired_screen_aspect_ratio" from the config file, that may be 4/3,
16/9, 16/10, 5/3 and 5/4. Optionaly if "USE_ALL_ASR" is defined (Can
be uncommented in opengl-graphics.h, like USE_OSD) all the aspect
ratios can be selected.
Regards,
Alejandro
More information about the Scummvm-devel
mailing list