[Scummvm-devel] Detecting patched games

[Eugene Sandulenko]

Hi team,

Addition of SCI engine brought an old issue which has been in my mind
for a while. That is hacked games with copy protection disabled. SCI
has plenty of them due to the game popularity, so is AGOS, AGI and
some other engines.

The patches are pretty often buggy, but if not, it is not good to support them.

The problem is that when we remove those detection entries, we
regularly get them reported again, which takes out resources.

Thus, I would like to ask your opinion. What do you guys think about
adding a special game flag like ADGF_PIRATED, and keep those entries
where applicable. But during detection instead of our 'please submit
md5' message show something like: "Hacked game variant detected.
Skipping".

Any thoughts?


Eugene