[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[52156] scummvm/trunk/configure
Max Horn
max at quendi.de
Tue Aug 17 15:39:54 CEST 2010
Am 17.08.2010 um 15:00 schrieb sev at users.sourceforge.net:
> Revision: 52156
> http://scummvm.svn.sourceforge.net/scummvm/?rev=52156&view=rev
> Author: sev
> Date: 2010-08-17 13:00:48 +0000 (Tue, 17 Aug 2010)
>
> Log Message:
> -----------
> CONFIGURE: Add -Wglobal-constructors to Darwin builds.
That's not a good way to do it. A good configure script should always strive to do things based on feature detection, not on fixed tables of systems. In this particular case, a test whether the compiler accepts -Wglobal-constructors would be preferable; or, if that is impossible, then at least a test whether the compiler is an LLVM driven gcc. As it is, your change broke compilation on older Mac OS X machines, where the default GCC was not LLVM based.
Bye,
Max
More information about the Scummvm-devel
mailing list