[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[52156] scummvm/trunk/configure

[Eugene Sandulenko]

On 17 August 2010 16:39, Max Horn <max at quendi.de> wrote:
>> CONFIGURE: Add -Wglobal-constructors to Darwin builds.
>
> That's not a good way to do it. A good configure script should always strive to do things based on feature detection, not on fixed tables of systems. In this particular case, a test whether the compiler accepts -Wglobal-constructors would be preferable; or, if that is impossible, then at least a test whether the compiler is an LLVM driven gcc. As it is, your change broke compilation on older Mac OS X machines, where the default GCC was not LLVM based.

Agreed, and I just committed a proper detection.


Eugene