[Scummvm-devel] setMouseCursor() keycolor

[Marcus Comstedt]

Here's a patch for review which removes the default value for the
keycolor parameter.

While I was doing inventory of all calls to CursorMan, I found one
rather peculiar thing:  The mohawk engine does provide the keycolor
explicitly, but in one case the color that it explicitly provides
is 0xFFFFFFFF!  The comment a few lines up says

        // Myst ME stores some cursors as 24bpp images instead of 8bpp

but if _pixelFormat is really a 24bpp format, and the engine really
wants white as the keycolor (unlikely as that seems), that would be
0xFFFFFF, not 0xFFFFFFFF.  I'm guessing this code is simply in an
unfinished state and isn't really supposed to work yet, but just in
case there is a rationale for using this value, i'd like to hear it.


  // Marcus


-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_keycolor_default.patch
Type: text/x-diff
Size: 6763 bytes
Desc: Patch to remove the default value for the keycolor	parameters in CursorMan methods
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20100107/b0a0ec2c/attachment.patch>