[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[53456] scummvm/trunk/engines/scumm/he/wiz_he.cpp
Eugene Sandulenko
sev at scummvm.org
Fri Oct 15 13:25:40 CEST 2010
On Fri, 15 Oct 2010 09:13:11 +1100
Travis Howell <kirben at optusnet.com.au> wrote:
> Why did you commit this untested patch? and to both branches? the
> patch was only just added to that tracker item, and was waiting for
> further feedback.
Well, my fault. I tested in on LE system, and it came from BE system. I
did not notice any problems with it so committed.
> That patch isn't the correct method to fix cursors, and would cause
> numerous patch glitches on a BE system, when any manipulation of
> wizImages is used. Since the decoding methods for wizImages rely on
> the palette been stored in LE.
>
> Please revert those changes.
As I mentioned in the bugreport yesterday, feel free to do that, i.e.
revert both commits and use correct fix.
Eugene
More information about the Scummvm-devel
mailing list