[Scummvm-devel] KYRA - Eye of the Beholder extension

[Johannes Schickel]

On 12/02/2011 01:45 AM, Tarek Soliman wrote:
>
> IMHO and based on what (little) I know:
>
> I don't think that is any different from the fact that ScummVM supports
> LoL today.
>
> Don't get me wrong, I love LoL and don't want to get it removed by any means.
>
> I am just trying to understand how adding EoB 1+2 will all of a suddenly affect
> things or change our focus or suddenly prevent us from claiming anything when
> LoL is right there in the "before" side of things.

That's were:

 > So now it might seem less of a bad thing to add it, because we maybe 
made a "mistake" in the past.

comes into play.

We did this once, not really concious about how the result would be, 
since back then we didn't have really much code for LoL. On the other 
hand now we have the EoB 1+2 code. By now conciously making the decision 
to include an(other) RPG (sub)"engine" into ScummVM, we conciously make 
the decision to support big portions of non-adventure game related code.

You are right if we really don't want any big portions of non-adventure 
code in ScummVM, then a logical result would be that we should remove 
the LoL code. Then again I don't really think we need to go that far. 
But if we start to add RPG only code in the amount that we need for EoB 
1+2, then saying we only support it, because it's inside an adventure 
engine really doesn't reflect the technical truth IMHO. In fact I would 
say it's not a real honest statement then. Thus I consider this rather 
as a focus shift.


>> If you consider any game which uses utility functions and file formats
>> from Kyra1-3 as a subset of the adventure engine, when we can probably
>> support Dune 2 and Command&  Conquer 1 and 2 too.
> Sorry for the ignorance, but am I safe in assuming that the above implies
> that LoL shares more with Kyra1,2,3 than EoB shares with Kyra1,2,3?
>
> I am confused about this, because I was under the impression that the
> difference between LoL and Kyra is greater than or equal to the difference
> between LoL and EoB1,2.

It's probably true that the difference between Kyra1-3 and LoL is bigger 
than between LoL and EoB. But not sure why you think LoL shares more 
with Kyra1-3 than EoB does with Kyra1-3? The statement you quote just 
illustrates that if only that few of code sharing between the adventure 
and non-adventure parts suffice for us to add it, we could use the same 
argument to add support for the mentioned games.

// Johannes